Skip to content

Use the same method to get url in all spring filters#5656

Merged
romtsn merged 10 commits into
mainfrom
fix/spring-urls
Jul 16, 2026
Merged

Use the same method to get url in all spring filters#5656
romtsn merged 10 commits into
mainfrom
fix/spring-urls

Conversation

@lbloder

@lbloder lbloder commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@sentry

sentry Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.48.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 315.28 ms 371.94 ms 56.66 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
382d6c1 306.85 ms 368.70 ms 61.85 ms
e63ad34 323.67 ms 390.33 ms 66.67 ms
91bb874 310.68 ms 359.24 ms 48.56 ms
5865051 324.24 ms 356.02 ms 31.78 ms
806307f 357.85 ms 424.64 ms 66.79 ms
b193867 331.08 ms 397.06 ms 65.98 ms
0eaac1e 322.53 ms 389.31 ms 66.78 ms
6405ec5 310.88 ms 354.56 ms 43.69 ms
d15471f 310.66 ms 368.19 ms 57.53 ms
951caf7 323.66 ms 392.82 ms 69.16 ms

App size

Revision Plain With Sentry Diff
382d6c1 1.58 MiB 2.29 MiB 719.85 KiB
e63ad34 0 B 0 B 0 B
91bb874 1.58 MiB 2.13 MiB 559.07 KiB
5865051 0 B 0 B 0 B
806307f 1.58 MiB 2.10 MiB 533.42 KiB
b193867 1.58 MiB 2.19 MiB 620.00 KiB
0eaac1e 1.58 MiB 2.19 MiB 619.17 KiB
6405ec5 1.58 MiB 2.12 MiB 552.23 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
951caf7 1.58 MiB 2.13 MiB 558.77 KiB

Previous results on branch: fix/spring-urls

Startup times

Revision Plain With Sentry Diff
e7c3dbe 315.67 ms 347.13 ms 31.46 ms
2250e97 363.21 ms 421.44 ms 58.23 ms

App size

Revision Plain With Sentry Diff
e7c3dbe 0 B 0 B 0 B
2250e97 0 B 0 B 0 B

@lbloder lbloder changed the title UIse the same method to get url in all spring filters Use the same method to get url in all spring filters Jun 29, 2026
lbloder
lbloder commented Jul 6, 2026
View reviewed changes
Comment thread sentry-spring-7/src/main/java/io/sentry/spring7/tracing/SentrySpanClientWebRequestFilter.java Outdated
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/HttpConnection.java

2 similar comments
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/HttpConnection.java

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/HttpConnection.java

lbloder
lbloder commented Jul 10, 2026
View reviewed changes
Comment thread sentry/src/main/java/io/sentry/transport/HttpConnection.java
@romtsn romtsn force-pushed the fix/spring-urls branch from 512dd07 to bd7b260 Compare July 16, 2026 08:50
@romtsn romtsn marked this pull request as ready for review July 16, 2026 08:50
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/HttpConnection.java

@romtsn romtsn enabled auto-merge (squash) July 16, 2026 09:17
@romtsn romtsn merged commit 6424ca9 into main Jul 16, 2026
71 checks passed
@romtsn romtsn deleted the fix/spring-urls branch July 16, 2026 09:18
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Jul 16, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinauer adinauer adinauer left review comments
@romtsn romtsn romtsn approved these changes
@markushi markushi Awaiting requested review from markushi markushi is a code owner
@runningcode runningcode Awaiting requested review from runningcode runningcode is a code owner
@0xadam-brown 0xadam-brown Awaiting requested review from 0xadam-brown 0xadam-brown is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lbloder @adinauer @romtsn @getsentry-bot